[coreboot-gerrit] Change in coreboot[master]: soc/intel/{common,skl,icl,cnl}: Move some bootblock code to common lo...

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35277 )

Change subject: soc/intel/{common,skl,icl,cnl}: Move some bootblock code to common location
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35277/1/src/soc/intel/common/baseco... 
File src/soc/intel/common/basecode/bootblock/Kconfig:

https://review.coreboot.org/c/coreboot/+/35277/1/src/soc/intel/common/baseco... 
PS1, Line 4:
> help text ?
> Done

https://review.coreboot.org/c/coreboot/+/35277/1/src/soc/intel/common/baseco... 
File src/soc/intel/common/basecode/bootblock/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35277/1/src/soc/intel/common/baseco... 
PS1, Line 1: bootblock-$(CONFIG_SOC_INTEL_COMMON_BASECODE_BOOTBLOCK) +=bootblock.c
> space ?
> Done