2 Dec
2019
2 Dec
'19
2:49 p.m.
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36041 )
Change subject: drivers/gfx: Add generic graphics with SSDT generator ......................................................................
Patch Set 13: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36041/13/src/drivers/generic/gfx/gf... File src/drivers/generic/gfx/gfx.c:
https://review.coreboot.org/c/coreboot/+/36041/13/src/drivers/generic/gfx/gf... PS13, Line 59: privacy_screen_callbacks Could this become a structure instead of an array? That would let us name each member.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36041
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida520dd7aad81ee7c1e5f2d0d3f5cc1a766d78a0
Gerrit-Change-Number: 36041
Gerrit-PatchSet: 13
Gerrit-Owner: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Rajat Jain rajatja@google.com
Gerrit-Reviewer: Simon Glass sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 02 Dec 2019 22:49:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment