Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46054 )
Change subject: mb/intel/adlrvp: Add initial ADL-P mainboard code ......................................................................
Patch Set 4:
(2 comments)
Thanks for starting the review Angel. So quick update for you. rest need code change and will do by tomorrow morning.
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/board_info.txt:
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... PS3, Line 6: y
I don't think flashrom supports ADL yet.
https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+... 😎
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... PS3, Line 16:
No ACPI?
will add in incremental patch :) as off now added only till booting romstage early.