Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38547 )
Change subject: device: Enumerate device based on IORESOURCE_ASSIGNED ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38547/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38547/10//COMMIT_MSG@16 PS10, Line 16: device with FIXED resources.
Please describe what different semantics you need, compared to […]
As quoted below from resource.h: /* An IO resource that has been assigned a value */ #define IORESOURCE_ASSIGNED 0x40000000 /* An IO resource the allocator must not change */ #define IORESOURCE_FIXED 0x80000000 These two macros are different.
https://review.coreboot.org/c/coreboot/+/38547/6/src/device/device.c File src/device/device.c:
https://review.coreboot.org/c/coreboot/+/38547/6/src/device/device.c@383 PS6, Line 383: /* Skip if IO resource was assigned */
Why not just avoid calling this function all together by adding a condition in dev_configure(), like […]
Do you mean avoid calling compute_resources()? Because we need to walk through all the resources on the current bus and compute the amount of address space taken by them, I am not sure how this can be avoided. We are just skip resources that are already assigned.