Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38778 )
Change subject: vboot: correct workbuf size when VBOOT_STARTS_IN_ROMSTAGE
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38778/1/src/security/vboot/common.c
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/38778/1/src/security/vboot/common.c...
PS1, Line 108: rv = vb2api_init(wb_cbmem, cbmem_size, &vboot_ctx);
nit: not sure if it's a great idea for visibility to pull the if and the else so far apart from each […]
Good point, it does look a bit awkward. I'll merge the comments into one block atop the if.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38778
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie09c39f960b3f14f3a64c648eee6ca3f23214d9a
Gerrit-Change-Number: 38778
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 09 Feb 2020 08:29:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment