25 Nov
2021
25 Nov
'21
3:29 p.m.
Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Julius Werner. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59194 )
Change subject: src/lib: Add CBMEM tag id to parse ddr information ......................................................................
Patch Set 5:
(1 comment)
File src/commonlib/include/commonlib/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/59194/comment/2a69ae26_00ec359c PS5, Line 82: 0x10 maybe write it down in 0x%08x format like the rest? Also a more 'random looking' number might be better?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I594bd9266a6379e3a85de507eaf4c56619b17a6f
Gerrit-Change-Number: 59194
Gerrit-PatchSet: 5
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: mturney mturney quic_mturney@quicinc.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: mturney mturney quic_mturney@quicinc.com
Gerrit-Comment-Date: Thu, 25 Nov 2021 14:29:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment