[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Speed up postcar loading using intermediate cac...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34791 )

Change subject: soc/intel/cannonlake: Speed up postcar loading using intermediate caching
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34791/4/src/soc/intel/cannonlake/ro... 
File src/soc/intel/cannonlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/34791/4/src/soc/intel/cannonlake/ro... 
PS4, Line 142: set_var_mtrr
> Don't you have to disable caching before configuring MTRR's?

disable_cache() and enable_cache() around will cause sluggishness. i have same exp in fast_spi_cache_bios_region()