Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32246 )
Change subject: mb/google/octopus: Disable WLAN prior the entry of S5
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32246/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32246/1//COMMIT_MSG@11
PS1, Line 11: ODM found issue is gone if they remove the WLAN card.
Please add a blank line above, or, if it is not a paragraph, put it on the line above.
done
https://review.coreboot.org/#/c/32246/1//COMMIT_MSG@14
PS1, Line 14:
Does this affect the shutdown time?
nope
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8e81022b8c9b63bc75e5cc14121233222da7595
Gerrit-Change-Number: 32246
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 09 Apr 2019 09:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment