Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40404 )
Change subject: mmio: Use unsigned integers for bit operations ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40404/3/src/include/device/mmio.h File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/40404/3/src/include/device/mmio.h@1... PS3, Line 148: (unsigned int)(value) nit: Would it maybe be useful to also mask this off with the size? That way you could use it with signed negative numbers and accidental misuse can't overflow into other fields.