Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant ......................................................................
Patch Set 28:
Patch Set 28:
Patch Set 28: Code-Review+1
Patch Set 28:
Is there any flaw that prevents this commit from being Code-Review +2 now?
There are some unresolved comments which should be addressed or marked as resolved.
To expand on this, until all comments are marked resolved, the patch can't be merged even if it has +2. If you look in the code review section, you'll see the "All-Comments resolved" section marked "No votes."
To see what still needs to be addressed, click on one of the patchset selectors at the top of the files section and look for anything that says 'X comments, Y unresolved'.
Thanks. I have missed the point of "All-Comments resolved" until now.