Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42274 )
Change subject: mb/google/volteer/variants/terrador: Enable CA Mirror
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42274/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42274/3//COMMIT_MSG@7
PS3, Line 7: CA
Cmd?
There are different terms, let's use Cmd Mirror to align
https://review.coreboot.org/c/coreboot/+/42274/3//COMMIT_MSG@7
PS3, Line 7: mb/google/volteer/variants/terrador: Enable CA Mirror
Please summarize, why CmdMirror is good to have, and what it improves.
Can you add below in commit message?
Enable CmdMirror for Terrador to achieve optimum routing from SoC to DRAMs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0db9fff0dddf35c99a6cb2a90d40886ed8e18686
Gerrit-Change-Number: 42274
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Jun 2020 10:09:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment