Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33185 )
Change subject: libpayload/i8042/keyboard: Fix return value check for keyboard_cmd
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33185/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33185/3//COMMIT_MSG@21
PS3, Line 21: anymore.
Could you please clarify, if only the log message was the problem, or if the keyboard also did not work. In QEMU, there was just the log message, but the keyboard worked in QEMU and on the ASRock E350M1 – in contrast to before the commit, where it did not work.
On the coreboot mailing list, Martin reported [1], that with the commit, nothing worked for him anymore.
[1]: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/QQTZ3...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcadaae12e0a44e404a1d98c6deb633d97058203
Gerrit-Change-Number: 33185
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Kepplinger
martink@posteo.de
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 04 Jun 2019 11:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment