Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36015 )
Change subject: mb/google/octopus: Override VBT selection for Blooguard
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36015/3/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/bloog/variant.c:
https://review.coreboot.org/c/coreboot/+/36015/3/src/mainboard/google/octopu...
PS3, Line 40: if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36)
Also add them to the enum list.
https://review.coreboot.org/c/coreboot/+/36015/3/src/mainboard/google/octopu...
PS3, Line 43: if (sku_id == 49 || sku_id == 50 || sku_id == 51 || sku_id == 52)
use the enum to keep consistent.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36a313fd2beacb878da7383f733e206067c1c0fb
Gerrit-Change-Number: 36015
Gerrit-PatchSet: 3
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Oct 2019 02:39:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment