Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34175 )
Change subject: mb/google/hatch: Enable LPIT inclusion in DSDT
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34175/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34175/2//COMMIT_MSG@13
PS2, Line 13: compiles
Can you please test S3 and S0ix to ensure both work fine?
1. Using suspend_stress_test (at least 100 iterations)
2. Using echo {mem,freeze} > /sys/power/state. P.S. You need to set /sys/power/mem_sleep correctly too
Also, do you observe any issues with eventlog i.e. logging of S0ix enter/exit happening twice for a single iteration? Any other issues?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34175
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8ebff3db091257e8452869636c0e024f3123e8b
Gerrit-Change-Number: 34175
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Evan Green
evgreen@chromium.org
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-Comment-Date: Tue, 09 Jul 2019 20:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment