Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35514 )
Change subject: device/pci: fix legacy VGA encoding
......................................................................
Patch Set 4:
Hi Kyösti,
sorry, I originally proposed to handle it in set_vga_bridge_bit(). Didn't
like it either, when I saw it, hence CB:35516. I'll try to find CardBus
specs to confirm if they added the bit there, too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35514
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29e37ac69d68ef8e0f37ef02660a53101f254992
Gerrit-Change-Number: 35514
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 21 Sep 2019 14:36:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment