Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31617 )
Change subject: superio/ite/it8613e: add support for ITE IT8613E
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/31617/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31617/1//COMMIT_MSG@10
PS1, Line 10: have
has
https://review.coreboot.org/#/c/31617/1//COMMIT_MSG@11
PS1, Line 11: datasheet
What revision?
https://review.coreboot.org/#/c/31617/1/src/superio/ite/it8613e/superio.c
File src/superio/ite/it8613e/superio.c:
https://review.coreboot.org/#/c/31617/1/src/superio/ite/it8613e/superio.c@55
PS1, Line 55: .read_resources = pnp_read_resources,
Use tabs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31617
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73c083b7019163c1203a5aabbef7d9d8f5ccb16a
Gerrit-Change-Number: 31617
Gerrit-PatchSet: 2
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Feb 2019 12:34:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
