Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40281 )
Change subject: src/mainboard/lenovo/t420s/devicetree.cb: Fix PCIe port definitions ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard/lenovo/t420s/devicetree.cb: Fix PCIe port definitions
I’d use: […]
Uh, this change doesn't directly enable USB 3.0. It fixes the PCIe root port settings and comments. As a result, the USB 3.0 controller behind a previously-disabled root port is now detected and works.
So I would keep the original phrase, but still shorten the path:
mb/lenovo/t420s/devicetree: Fix PCIe port definitions
https://review.coreboot.org/c/coreboot/+/40281/1//COMMIT_MSG@10 PS1, Line 10: Enabled RP#5, disabled RP#7 and : updated comments accordingly.
So, enable RP#5, disable RP#7, and update comments accordingly.
(To make it clear, the suggestion is to use "timeless present" for the changes that the commit does)