Attention is currently required from: Jakub Czapiga, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78904?usp=email )
Change subject: fmap: Eliminate some impossible code paths ......................................................................
Patch Set 1:
(4 comments)
File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/78904/comment/f68bdb0c_103fc9c0 : PS1, Line 36: 0x%x %#x
https://review.coreboot.org/c/coreboot/+/78904/comment/354d4de1_eb4a6f41 : PS1, Line 36: FMAP missing or corrupted Is it more straightforward to say `Invalid FMAP signature`?
https://review.coreboot.org/c/coreboot/+/78904/comment/06d23592_dea6d29f : PS1, Line 37: FMAP_OFFSET); indent
https://review.coreboot.org/c/coreboot/+/78904/comment/5cc019ec_03b1d6eb : PS1, Line 125: if (!CONFIG(NO_FMAP_CACHE) && ENV_ROMSTAGE_OR_BEFORE) Also `&& !ENV_SMM`?