Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Make stage cache kconfig selection proper
......................................................................
Patch Set 19:
Patch Set 19:
NO_STAGE_CACHE --> already exists
USE_EXTERNAL_STAGE_CACHE --> depends on !NO_STAGE_CACHE (can be selected by a mainboard/SoC that provides implementation of external stage cache).
Only i issue i saw here with AMD, Gardenia board, where HAVE_ACPI_TABLE is not selected hence NO_STAGE_CACHE is enable and in same time, mainboard also selects HAVE_EXTERNAL_STAGE_CACHE. As per this mainboard expectation, it might need to make use of stage_cache hence I can't make USE_EXTERNAL_STAGE_CACHE --> depends on !NO_STAGE_CACHE
That sounds like a bug in the board?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 19
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Jul 2019 06:42:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment