V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45028 )
Change subject: common/block/pmc: Add a check to program the PchPmPwrCycDur ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45028/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/45028/3/src/soc/intel/common/block/... PS3, Line 223: /* This function ensures that the duration programmed in the PchPmPwrCycDur will never be
Done
https://review.coreboot.org/c/coreboot/+/45028/3/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/45028/3/src/soc/intel/common/block/... PS3, Line 668: /* This function ensures that the duration programmed in the PchPmPwrCycDur will never be : * smaller than the SLP_Sx assertion widths. : * If the pm_pwr_cyc_dur is less than any of the SLP_Sx assertion widths then it returns the : * default value PCH_PM_PWR_CYC_DUR. : */
Done