Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41648 )
Change subject: mb/google/poppy: Create sylas variant ......................................................................
Patch Set 4:
(7 comments)
Multiple VBT files are added. Is this correct, or were they copied from Nami?
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/sylas/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... PS4, Line 37: register "SataSalpSupport" = "0" : register "SataMode" = "0" If SATA is disabled, these options are unnecessary
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... PS4, Line 54: 3 SaGv_Enabled
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... PS4, Line 189: Add another tab?
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... PS4, Line 437: Remove one space
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... PS4, Line 450: Add another space
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/sylas/gpio.c:
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... PS4, Line 428: case SKU_0_VAYNE: I am not sure, are all of these valid SKUs? They seem to be copied from nami
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/sylas/nhlt.c:
https://review.coreboot.org/c/coreboot/+/41648/4/src/mainboard/google/poppy/... PS4, Line 28: NAMIMAX Is this correct?