Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40141 )
Change subject: Kill the dead_code macro
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40141/5/src/lib/bootmode.c
File src/lib/bootmode.c:
https://review.coreboot.org/c/coreboot/+/40141/5/src/lib/bootmode.c@37
PS5, Line 37: /* Must always select MUST_REQUEST_DISPLAY when using this function. */
: return you_need_to_select_vboot_must_request_display();
i'd put this in an else block and not just after the if/else if
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06f825e045d3305dd8ab81311fd2d003d03ae43a
Gerrit-Change-Number: 40141
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 04 Apr 2020 22:07:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment