Change subject: soc/intel/tigerlake: Fix stale device pointer usage
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Would it be easier to avoid this mistake in the future, if we split the logic into two lines.
One to assign dev to the correct device, and then the next one to set the UPD?
In the original CL, the code was written in the way you mentioned. But there was a comment to use the ternary operator instead.
i'd also prefer to read the i/t/e implementation.
note that there are 2 more cases like this just a few lines down
that use the i/t/e version.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43cccd32589d75a9b0c7e60f8c82b19bbe6b69a7
Gerrit-Change-Number: 39405
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 10 Mar 2020 01:20:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment