Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31757 )
Change subject: [WIP] device/pci_ops: Store pci_devfn_t in devicetree
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31757/5/src/include/device/pci_ops....
File src/include/device/pci_ops.h:
https://review.coreboot.org/c/coreboot/+/31757/5/src/include/device/pci_ops....
PS5, Line 46: return dev->path.pci.devfn;
This seems to be the meat of the patch, but doesn't that need various changes elsewhere to work?
Ya. Enumeration needs to update the bus values of the struct devices that are hanging off the bus.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31757
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie36a43ee0cc4770f5dbd2671ce188c9ade9af2cf
Gerrit-Change-Number: 31757
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 27 Sep 2019 22:18:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment