4 Feb
2019
4 Feb
'19
1:56 p.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30973 )
Change subject: src/mainboard/sony: Add Sony VPCEH2K1E ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/30973/4/src/mainboard/sony/vpceh2k1e/romstag... File src/mainboard/sony/vpceh2k1e/romstage.c:
https://review.coreboot.org/#/c/30973/4/src/mainboard/sony/vpceh2k1e/romstag... PS4, Line 40: pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x88, 0x000c1641);
Should LPC_GENx_DEC be set here, in devicetree or both?
if you don't need to access those IO ranges in the romstage you should remove it here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30973
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf324f1276611ab06d5906cab87ad538bfad7218
Gerrit-Change-Number: 30973
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Feb 2019 12:56:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment