Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33799 )
Change subject: src/lib/hexdump: Use size_t for length
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33799/3/src/lib/hexdump.c
File src/lib/hexdump.c:
https://review.coreboot.org/#/c/33799/3/src/lib/hexdump.c@26
PS3, Line 26: int j, num_bytes
It's probably better to have them both as size_t, since otherwise there will be a size_t -> int conversion warning when calculating num_bytes on line 29.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29a7ae8c499bb1e8ab7c8741b2dfb7663d82a362
Gerrit-Change-Number: 33799
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Jun 2019 15:14:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment