Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43687 )
Change subject: nb/intel/ironlake/acpi/hostbridge.asl: Use ASL 2.0 syntax ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43687/1/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/acpi/hostbridge.asl:
https://review.coreboot.org/c/coreboot/+/43687/1/src/northbridge/intel/ironl... PS1, Line 112: If (Acquire (CTCM, 100)) { : Return (0) : } : If (LEqual (CTCD, CTCC)) { : Release (CTC
Are these in ASL1 syntax for sandybridge as well? if so, I'd propose keeping them here (to minimize […]
Yes, I'll take care of that. Note that `Acquire` isn't old syntax.
https://review.coreboot.org/c/coreboot/+/43687/1/src/northbridge/intel/ironl... PS1, Line 148: If (Acquire (CTCM, 100)) {
old syntax
No