Attention is currently required from: Tim Wawrzynczak, Derek Huang. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58002 )
Change subject: src/ec/google/chromeec: Make USB-C mux operation generic ......................................................................
Patch Set 2:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58002/comment/a37a0a84_8c0b5c1b PS2, Line 9: Create a generic EC interface for USB-C mux operations. Register : Chrome EC USB-C mux operations to the generic interface. These should be split into two CLs:
1. Generic interface for providing USB-C mux ops 2. Interface implementation for Chrome EC.
File src/ec/google/chromeec/usbc_mux.c:
PS2: SPDX license header is missing.
https://review.coreboot.org/c/coreboot/+/58002/comment/a6a85dca_7dc124f6 PS2, Line 2: #include <usbc_mux.h>
File src/include/usbc_mux.h:
PS2: SPDX license header is missing.
https://review.coreboot.org/c/coreboot/+/58002/comment/461a4851_8ab9065e PS2, Line 5: Activ Active
https://review.coreboot.org/c/coreboot/+/58002/comment/15d38009_ef3eecf9 PS2, Line 6: * What are the options? What do 0 and 1 indicate?
https://review.coreboot.org/c/coreboot/+/58002/comment/dcc94cfc_ca732a2d PS2, Line 9: bool ufp; : bool acc; No comments for these members?
https://review.coreboot.org/c/coreboot/+/58002/comment/ef2646a0_958c1bb5 PS2, Line 11: uint8_t Why not bool?
https://review.coreboot.org/c/coreboot/+/58002/comment/293a15a7_f2398ca1 PS2, Line 33: int long
https://review.coreboot.org/c/coreboot/+/58002/comment/467b83d4_9934bfc3 PS2, Line 51: int long