Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31066 )
Change subject: mb/lenovo/x131e: enable WWAN detection
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31066/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31066/1//COMMIT_MSG@10
PS1, Line 10:
Unfortunately I can't test that mSATA works. […]
Nice, but it’d be great if you added that.
https://review.coreboot.org/#/c/31066/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31066/2//COMMIT_MSG@9
PS2, Line 9: Per schematic. Functionality untested.
… but non-presence is detected fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31066
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a
Gerrit-Change-Number: 31066
Gerrit-PatchSet: 2
Gerrit-Owner: James
jye836@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: James
jye836@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 Feb 2019 11:42:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: James
jye836@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment