[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: add UPD for USB3 phy setting adjust

[Martin Roth (Code Review)]

Attention is currently required from: chris wang.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50240 )

Change subject: soc/amd/picasso: add UPD for USB3 phy setting adjust
......................................................................

Patch Set 6:

(1 comment)

File src/soc/amd/picasso/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/50240/comment/5e9a294d_5d599309 
PS4, Line 131: memcpy(&scfg->usb_3_port0_phy_tune, &cfg->usb3_phy_tune_params[0],
             : 			sizeof(scfg->usb_3_port0_phy_tune[0]));
> For the RX_EQ_DELTA_IQ_OVRD_VAL and RX_EQ_DELTA_IQ_OVRD_EN. […]

Right, I'm just wondering if the enable should be more.  Right now if we want to update any parameter, we need to update all of them, because there's just the single enable.  I'm fine with that, but it should be clear that any fields that aren't listed in the devicetree file are being set to 0, not being left they way they were.