Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31488 )
Change subject: soc/amd/common: Identify AGESA call pattern ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/31488/5/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/31488/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 68: AGESA_STATUS
Definitely not recoverable, as AGESA would not know what is required on a particular call. […]
AMD_CREATE_STRUCT may return AGESA_UNSUPPORTED. In this case, the requested entrypoint (aip->AgesaFunctionName) structure is not allocated, but there is also no reason to call that entrypoint then.
https://review.coreboot.org/#/c/31488/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 431: } If amd_create_struct() returned AGESA_UNSUPPORTED, we can just return here already, blob would not do anything. I'll prepare followup for this.