Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34995 )
Change subject: arch/x86: Add postcar_frame_setup_top_of_dram_usage() API
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34995/3/src/arch/x86/postcar_loader...
File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/34995/3/src/arch/x86/postcar_loader...
PS3, Line 153: MTRR_TYPE_WRBACK);
I only want the four lines above added to cannonlake/romstage/romstage.c: car_stage_entry(). […]
I understood but isn't it also true that we want to also pass this savings into some common code like postcar_loader.c for all soc to get benefit out ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34995
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59432c02e04af1b931d77de3f6652b0327ca82bb
Gerrit-Change-Number: 34995
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Aug 2019 10:00:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment