Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31435 )
Change subject: mb/ocp/monolake: fix for booting issues + tmp and ipmi support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31435/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31435/1/src/arch/x86/smbios.c@645 PS1, Line 645: t->length = len; The code here is a little odd. Each table has to be followed by two null bytes. So the `t->length` has to be two less than the number of bytes zeroed and reserved (`*current +=` below).
For other tables this is done by having two extra bytes at the end of the struct declaration (`u8 eos[2]`). It's an odd pattern, but might be worth to align this one here to avoid more confusion.
And please split the SMBIOS change out into a separate commit.