Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32607 )
Change subject: ec/lenovo/h8: Add VBOOT board support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32607/1/src/ec/lenovo/h8/vboot.c
File src/ec/lenovo/h8/vboot.c:
https://review.coreboot.org/#/c/32607/1/src/ec/lenovo/h8/vboot.c@49
PS1, Line 49: int get_write_protect_state(void)
This should something specific to the flash protection interface. […]
It is. It reflects the current hardware write protection state as used on chromebooks. As there's none it's always false.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32607
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c682431b3f09839db265259205104bd9ef4abfc
Gerrit-Change-Number: 32607
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Mon, 06 May 2019 08:53:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-MessageType: comment