Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44106 )
Change subject: src/soc/intel/common: Move common HDA registers to <device/azalia_device.h> ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/44106/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44106/4//COMMIT_MSG@7 PS4, Line 7: src/soc/intel/common soc/intel/common
https://review.coreboot.org/c/coreboot/+/44106/4/src/include/device/azalia_d... File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/44106/4/src/include/device/azalia_d... PS4, Line 9: #include <stdint.h> Don't change this in this commit
https://review.coreboot.org/c/coreboot/+/44106/4/src/include/device/azalia_d... PS4, Line 19: #define HDA_ICII_VALID (1 << 1) Are these registers standard? I would expect them to be, but it's worth checking that.
https://review.coreboot.org/c/coreboot/+/44106/4/src/soc/intel/common/hda_ve... File src/soc/intel/common/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44106/4/src/soc/intel/common/hda_ve... PS4, Line 6: #include <device/azalia_device.h> Keep includes ordered in alphabetical order?