Attention is currently required from: Joel Kitching, Martin Roth, zanxi chen, Jitao Shi, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49830 )
Change subject: mb/google/kukui: Add panel for Katsu
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49830/comment/b0fa42f7_21ccc4f7
PS2, Line 29: ramstage-$(CONFIG_BOARD_GOOGLE_KATSU) += panel_katsu.c
please move this to the place after kakadu (sorted ordering).
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59a02198bc0e13f2760677ae4ea3eb05eb883464
Gerrit-Change-Number: 49830
Gerrit-PatchSet: 3
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Joel Kitching
kitching@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 25 Jan 2021 02:05:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment