Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42523 )
Change subject: [WIP] soc/amd/common: Place guards for ACPIMMIO on ENV_ARM
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42523/7/src/soc/amd/picasso/i2c.c
File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42523/7/src/soc/amd/picasso/i2c.c@5...
PS7, Line 55: switch (dev->path.mmio.addr) {
If we continue with the ideological view that no x86 memory space symbols should appear in ARCH_VERS […]
You could just use the i2c_bus_address[x] values? I don't think those case statements will hold up, but that approach should work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cb1b5a90023ebc4359835be716c5e3f9451df60
Gerrit-Change-Number: 42523
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 15:20:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment