Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48246 )
Change subject: soc/intel/common/block/acpi: Add soc MADT IOAPIC hook ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... PS9, Line 91:
nit: extra tab not required here and on next line.
Ack
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... PS9, Line 77: */
nit: It might be helpful to add the information here that if SoC does not provide a custom implement […]
I'll mention it uses the default, but not the code since that self documenting and could change and then the comment in the h file will be out of sync...
https://review.coreboot.org/c/coreboot/+/48246/9/src/soc/intel/common/block/... PS9, Line 78: struct madt_ioapic_info *
+1
Yes, good point.