Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p ......................................................................
Patch Set 1:
(6 comments)
Please addd documentation as well.
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 71: subsystemid 0x17aa 0x220e missing smbios_slot_desc
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 74: subsystemid 0x17aa 0x220e missing smbios_slot_desc
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 156: f on, for nvidia GPU
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 20: const u32 cim_verb_data[] = { missing verbs
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/smihandler.c:
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 31: { can be removed, already done in h8.c
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 37: int mainboard_io_trap_handler(int smif) can be removed as it has no purpose