uwe.poeche@siemens.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36643 )
Change subject: src/mainboard/siemens: Use PTN3460 chip driver ......................................................................
Patch Set 3:
(46 comments)
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c:
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 22: D
use lowercase here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 23: D
same here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 30:
no tab, just space here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 34: all needed information
Here you just read the EDID data. […]
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 36:
no tab, just space here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 43: to
Either add something here or remove the "to"
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 50: ; *
please remove
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 50: pf
of
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 60:
no tab, just space here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 73: get
got
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 81: I2C slave address
I can't see how helpful this is here. […]
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c:
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 22: D
lower case
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 23: D
same here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 30:
no tab, just space here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 34: all needed information
EDID data
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 36:
no tab, just space here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 43: to
remove or add more text
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 50: pf
of
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 50: ; *
please remove
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 52: to
to be
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 60:
no tab, just space here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 73: get
got
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 87: signal
"lanes" would be the better word here.
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 89: I2C slave address
I can't see how helpful this is here. […]
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c:
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 45: D
lower case
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 46: D
same here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 53:
space, not tab
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 57: all needed information
EDID data
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 61:
space, not tab please.
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 68: to
add more text or delete
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 75: pf
of
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 75: ; *
please remove
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 85:
space
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_ap... PS2, Line 112: signal
lane
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... File src/mainboard/siemens/mc_tcu3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 56: I2C slave address
I can't see how helpful this is here. […]
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... File src/mainboard/siemens/mc_tcu3/lcd_panel.c:
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 81:
Ane reason for so many spaces here?
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 91:
no tab, just space here
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 95: all needed information
EDID data
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 97:
no tab, just space please
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 104: to
either add more text or remove
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 111: pf
of
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 111: ; *
plese remove
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 113: to
to be
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 124:
no tab, just space
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 137: get
got
Done
https://review.coreboot.org/c/coreboot/+/36643/2/src/mainboard/siemens/mc_tc... PS2, Line 156: signal
lane
Done