Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38863 )
Change subject: superio/common: Validate devicetree ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38863/2/src/superio/common/ssdt.c File src/superio/common/ssdt.c:
https://review.coreboot.org/c/coreboot/+/38863/2/src/superio/common/ssdt.c@1... PS2, Line 167: const u8 ldn = dev->path.pnp.device & 0xff; : const u8 vldn = (dev->path.pnp.device >> 8) & 0x7;
here *dev already gets dereferenced, the check that dev isn't 0 probably should be before and not af […]
And I guess that running the SSDT generator would not be possible, so an early return would be needed I guess?
https://review.coreboot.org/c/coreboot/+/38863/2/src/superio/common/ssdt.c@1... PS2, Line 184: BIOS_CRIT If it's a critical bug, shouldn't we return instead of trying to generate the SSDT?