Attention is currently required from: Christian Walter, Angel Pons. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63464 )
Change subject: mb/prodrive/atlas: Update kconfig ......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/prodrive/atlas/Kconfig:
https://review.coreboot.org/c/coreboot/+/63464/comment/e787b4a3_80233c63 PS2, Line 3: select ALDERLAKE_A0_CONFIGURE_PMC_DESCRIPTOR
This was removed in CB:63339
Done
https://review.coreboot.org/c/coreboot/+/63464/comment/fa05db2f_aed9ec34 PS2, Line 5: select DRIVERS_I2C_GENERIC : select DRIVERS_INTEL_DPTF : select DRIVERS_SPI_ACPI : select DRIVERS_USB_ACPI
These options enable various devicetree chip drivers, but just selecting them isn't really useful. […]
Yes actually all of these have been enabled in devicetree: device domain 0 on device ref pcie5 on end device ref igpu on end device ref dtt on end device ref pcie4_0 on end device ref pcie4_1 on end device ref crashlog off end device ref xhci on end device ref heci1 on end device ref sata on end device ref pcie_rp5 on end device ref pcie_rp6 on end device ref pcie_rp8 on end device ref pcie_rp9 on end device ref pcie_rp10 on end device ref uart0 on end device ref uart1 on end device ref p2sb on end device ref hda on end device ref smbus on end
Just that we did not add the kconfig last time.
https://review.coreboot.org/c/coreboot/+/63464/comment/1dbd3030_f5d12d9f PS2, Line 9: select DRIVERS_UART_8250IO
Why is this needed? AFAIK, the SerialIO UARTs are configured to use MMIO (INTEL_LPSS_UART_FOR_CONSOL […]
Because the current main debug UART we are using now is the EC UART. I think we could switch back to LPSS UART later on?
https://review.coreboot.org/c/coreboot/+/63464/comment/df683c7a_b1d839d0 PS2, Line 17: : config IGNORE_IASL_MISSING_DEPENDENCY : def_bool y
Why is this needed?
This is the common problem with IASL error for all ADL platforms.