Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34570 )
Change subject: cpu/x86/mp_init: Wait longer with serial enabled
......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34570/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34570/1//COMMIT_MSG@13
PS1, Line 13: to
too
Done
https://review.coreboot.org/c/coreboot/+/34570/1//COMMIT_MSG@15
PS1, Line 15: SuperMicro
Supermicro
Done
https://review.coreboot.org/c/coreboot/+/34570/1/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/34570/1/src/cpu/x86/mp_init.c@896
PS1, Line 896: /* The serial console is slow and has a spinlock.
That or the concise style.
According to https://doc.coreboot.org/coding_style.html C89 or C99 are mandatory. There's no mandatory coding style for comments, only preferred ones.
https://review.coreboot.org/c/coreboot/+/34570/1/src/cpu/x86/mp_init.c@897
PS1, Line 897: pickup
pick up
Done
https://review.coreboot.org/c/coreboot/+/34570/1/src/cpu/x86/mp_init.c@906
PS1, Line 906: expire_us = 100 * USECS_PER_MSEC;
Right, it should set a minimal limit.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34570
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id47df02a9238e66f2b628b9d6805858724bf30a9
Gerrit-Change-Number: 34570
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jul 2019 07:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment