Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46327 )
Change subject: soc/amd/picasso: Override weak functions for ioapic_id.
......................................................................
Patch Set 1:
Patch Set 1:
(2 comments)
Can’t this be done all in Kconfig?
Before Picasso, these values were hardcoded to MAX_CPU and MAX_CPU +1. Adding the helper function will help with any common code where the older program won't utilize the Kconfig option. The more i've been thinking about this, i'd like to look at the design for some of this ACPI stuff and redesign into common code so we don't have to copy paste each generation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46327
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f0403678d7b221e7f6e76c72b701a095f233c97
Gerrit-Change-Number: 46327
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Oct 2020 18:35:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment