[coreboot-gerrit] Change in coreboot[master]: soc/fsp_broadwell_de: fix flashconsole support for platform

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32880 )

Change subject: soc/fsp_broadwell_de: fix flashconsole support for platform
......................................................................

Patch Set 4: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/32880/4/src/southbridge/intel/commo... 
File src/southbridge/intel/common/spi.c:

https://review.coreboot.org/c/coreboot/+/32880/4/src/southbridge/intel/commo... 
PS4, Line 165: #if CONFIG(DEBUG_SPI_FLASH)
OT: I will do something about the six copies we have for this.

https://review.coreboot.org/c/coreboot/+/32880/4/src/southbridge/intel/commo... 
PS4, Line 172: 	       v, ((unsigned) addr & 0xffff) - 0xf020);
That 0xf020 has been wrong ever since ich9?