Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35376 )
Change subject: coreboot:Add support for boot with tianocore payload ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35376/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/35376/5/src/mainboard/google/hatch/... PS5, Line 44: select USE_LEGACY_8254_TIME can add select USE_PM_TIMER after you make change in config name.
https://review.coreboot.org/c/coreboot/+/35376/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35376/5/src/mainboard/google/hatch/... PS5, Line 59: PmTimerDisabled
Should be set in SoC/Intel/ […]
Agree. you can move it to fsp_params.c directly and set it based on the Kconfig
https://review.coreboot.org/c/coreboot/+/35376/5/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/35376/5/src/soc/intel/common/block/... PS5, Line 16: USE_PM_TIMER_DISABLED
Inverse: USE_PM_TIMER
or USE_ACPI_PM_TIMER