Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34246 )
Change subject: mb/google/hatch: Change SerialIoDevMode for I2C, SPI, and UART
......................................................................
Patch Set 1:
(1 comment)
I
https://review.coreboot.org/c/coreboot/+/34246/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34246/1/src/mainboard/google/hatch/...
PS1, Line 4: PchSerialIoSkipInit
It looks like PchSerialIoSkipInit is not a valid setting for I2C and SPI. See https://review.coreboot.org/cgit/coreboot.git/tree/src/vendorcode/intel/fsp/....
We need to update soc common code to ensure that it does not allow this setting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87d1b6d1b8ac2453d2f50975fce133e39c17c7e3
Gerrit-Change-Number: 34246
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 11 Jul 2019 19:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment