Attention is currently required from: Hung-Te Lin, Jarried Lin, agogo.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Initialize MCUPM ......................................................................
Patch Set 9:
(1 comment)
File src/soc/mediatek/mt8196/mcupm.c:
https://review.coreboot.org/c/coreboot/+/85888/comment/7e2aea9a_a7c515ec?usp... : PS6, Line 21: "[EB_SPMC] Polling MCU_PORT_SET_R0_0 timeout, %#x\n",
I think the log is fine as long as MTK thinks the information is enough for them to debug. […]
Sorry to re-open again. No, it’s an error message and not a debug message. In either case, I think the misunderstanding is, that you think these log messages are only for MediaTek developers. My view is, that later on also normal users are going to install coreboot on these devices and play with it, and the log messages – especially error message – should be as useful to them as possible.
[EB_SPMC] CPUEB_PROTECT_RDY not set after %d us, value %#x\n
would be much more useful in my opinion.