build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43804 )
Change subject: soc/amd/acpi: Move ACPI IVRS generation to coreboot ......................................................................
Patch Set 19:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43804/19/src/soc/amd/picasso/agesa_... File src/soc/amd/picasso/agesa_acpi.c:
https://review.coreboot.org/c/coreboot/+/43804/19/src/soc/amd/picasso/agesa_... PS19, Line 204: if (!root_level) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/43804/19/src/soc/amd/picasso/agesa_... PS19, Line 269: add_ivhd_device_entries(NULL, all_devices, 0, -1, &root_level, ¤t, &ivhd_40->length); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/19/src/soc/amd/picasso/agesa_... PS19, Line 339: add_ivhd_device_entries(NULL, all_devices, 0, -1, &root_level, ¤t, &ivhd_11->length); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/19/src/soc/amd/picasso/agesa_... PS19, Line 470: add_ivhd_device_entries(NULL, all_devices, 0, -1, &root_level, ¤t, &ivrs->ivhd.length); line over 96 characters