Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49016 )
Change subject: device: Select VGA_ROM_RUN for non-FSP solution with PCIE DGPU ......................................................................
Patch Set 4:
(8 comments)
Are we talking about pluggable discrete cards, or discrete chips soldered on the board?
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@9 PS4, Line 9: For onboard graphics initialization It’d be great, if you could be more specific to add, it’s about graphics in the payload (or OS without graphics drivers).
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@14 PS4, Line 14: platform need to needs
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@14 PS4, Line 14: In case of non-FSP solution, platform need to select VGA_ROM_RUN : Kconfig to perform graphics initialization for PCI-E based discrete : card through VGA OpRom (SoC or Mainboard user can't select VGA_ROM_RUN : directly because it's part of choice option). Some payloads, like SeaBIOS, are also able to run Option ROMs, so coreboot does not need to (and should not) execute then. (I see below, you reference SeaBIOS, but it would be great to rephrase this to avoid confusion.)
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@22 PS4, Line 22: updated update
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@25 PS4, Line 25: PCI-E DGPU As coreboot sometimes has problems executing Option ROMs, please say exactly which card and what Video BIOS Option ROM version.
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@26 PS4, Line 26: select selects
https://review.coreboot.org/c/coreboot/+/49016/4/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/49016/4/src/device/Kconfig@53 PS4, Line 53: discrete graphics card Is it really only related to discrete graphics cards?
https://review.coreboot.org/c/coreboot/+/49016/4/src/device/Kconfig@53 PS4, Line 53: need needs